refill-style icon indicating copy to clipboard operation
refill-style copied to clipboard

old: Texture dots

Open patriciogonzalezvivo opened this issue 8 years ago • 6 comments
trafficstars

Adding a sdf-shape that could be reused for other styles. How it works?

  • takes a SDF texture u_sdf
  • which can be transform into a fill or stroke shape
  • I replace the previous circle function with it

We now can do more complex patterns if we want : )

patriciogonzalezvivo avatar Dec 14 '16 19:12 patriciogonzalezvivo

Notes from discussion with @patriciogonzalezvivo:

  • Use a smaller dot texture, this one is quite big (78k), and I doubt the resolution is needed
  • Let's not include non-production files like the shader used to generate the dot. It's useful to save, but my goal is to have the bundler just be zip (e.g. not require any special bundling script that has to fetch additional files or exclude others).

bcamper avatar Dec 14 '16 20:12 bcamper

You could put the 'brick' tiling pattern into the SDF texture as well, to further simplify the shader!

matteblair avatar Dec 14 '16 20:12 matteblair

Yes @blair1618 ! that's next on my TODO... I will wait for this PR to merge so I don't introduce a lot of changes at once. cc @nvkelso @bcamper @sensescape

patriciogonzalezvivo avatar Dec 15 '16 14:12 patriciogonzalezvivo

@nvkelso @bcamper can we merge this?

patriciogonzalezvivo avatar Dec 16 '16 15:12 patriciogonzalezvivo

@patriciogonzalezvivo can you help @sensescape and I debug why tiny-dots: don't show up at all? This is affecting landuse styles like cemetery and garden. We've set them to medium-dots in the meantime.

nvkelso avatar Dec 28 '16 02:12 nvkelso

hi @nvkelso, not sure what you need. seams like an old PR that wasn't merge

patriciogonzalezvivo avatar Jan 04 '17 19:01 patriciogonzalezvivo