refill-style icon indicating copy to clipboard operation
refill-style copied to clipboard

Add shade of gray to building facades

Open sensescape opened this issue 9 years ago • 4 comments
trafficstars

@bcamper @patriciogonzalezvivo @nvkelso

Now that I'm using a texture, not sure how to add a slight shade of gray to the building facades.

screen shot 2016-02-26 at 1 39 06 pm

Shader here: https://github.com/tangrams/refill-style/blob/gh-pages/refill-style.yaml#L824-L838

But I'd like to be able to tweak the facade color in the buildings layer https://github.com/tangrams/refill-style/blob/gh-pages/refill-style.yaml#L2402

sensescape avatar Feb 26 '16 21:02 sensescape

Take a look to line 17 from here: http://tangrams.github.io/tangram-play/?scene=https://rawgit.com/tangrams/tangram-sandbox/gh-pages/styles/default.yaml#17.299999999999997/40.71666/-74.00843

color.rgb *= vec3(min((worldPosition().z*.001 + .5),1.));

patriciogonzalezvivo avatar Feb 26 '16 21:02 patriciogonzalezvivo

Better to use the technique from Eraser Map, since we tint texture buildings there. I actually removed that piece earlier today when I ported the EM code to here :)

On Fri, Feb 26, 2016 at 4:50 PM, Patricio Gonzalez Vivo < [email protected]> wrote:

Take a look to line 17 from here: http://tangrams.github.io/tangram-play/?scene=https://rawgit.com/tangrams/tangram-sandbox/gh-pages/styles/default.yaml#17.299999999999997/40.71666/-74.00843

color.rgb = vec3(min((worldPosition().z.001 + .5),1.));

— Reply to this email directly or view it on GitHub https://github.com/tangrams/refill-style/issues/18#issuecomment-189495083 .

bcamper avatar Feb 26 '16 22:02 bcamper

I think we can start with this from EM, and optimize once we see what our needs for Refill are:

https://github.com/tangrams/eraser-map/blob/gh-pages/eraser-map.yaml#L681-L707

bcamper avatar Feb 26 '16 22:02 bcamper

Thanks! Much better. Some were so faded they were disappearing. See below:

Before: screen shot 2016-02-26 at 3 23 39 pm

After: screen shot 2016-02-26 at 3 23 46 pm

sensescape avatar Feb 26 '16 23:02 sensescape