bubble-wrap icon indicating copy to clipboard operation
bubble-wrap copied to clipboard

Use partially evaluated ux_language_text_source functions

Open hjanetzek opened this issue 8 years ago • 2 comments

This change avoids some string allocations when ux_language/fallback is defined, making it slightly more efficient (at least with duktape)

hjanetzek avatar Nov 21 '16 15:11 hjanetzek

Looking at it again now: This change would break the fast-path for language updates I suggested :)

Edit: no this would still work - since on ES our JS StyleContext would need to be recreated after global changes.

'The first self-transforming map style'!

hjanetzek avatar Nov 28 '16 22:11 hjanetzek

I think I understand what's going on in this PR, but requesting that @bcamper gives it some pro-level JavaScript review.

nvkelso avatar Dec 09 '16 17:12 nvkelso