bubble-wrap
bubble-wrap copied to clipboard
tangrams
Zoom level 18 building extrusion
I noticed recently that at zoom level 18 all the buildings were being extruded, irrespective of whether they have any heigh information in the tiles or not. (Refer: https://github.com/tangrams/eraser-map/blob/gh-pages/eraser-map.yaml#L2315-L2336)
However, if a building has a height less than the default extrusion 20, then should it be extruded by building_height + 20?
Example:
In the screen shot below, the pointer is my parent's place in Delhi, which has some height (I added it to osm :D), but no other neighbouring building should have any height information in osm. I would have expected my parents building to be like a watch-tower here :P.
If a building has a height value, it should be extruded to just that height. If it does not have a height value, it should extrude to default height (20 in this case).
Logically my fix in #109 causes this (like Brett suggests). But I agree the effect can be weird. Let's use this issue to track tuning the extrusion at zoom 17/18+.
One solution: If the data height is less than 20, we should probably force it to be 20 for rendering purposes.
We're also extruding to 20 tiny backyard sheds, those should probably be 10m instead.