Thomas Andraschko

Results 342 comments of Thomas Andraschko

+1 for tests in generell Just do it as you like :) We also need think where we host the project later, see: https://groups.google.com/forum/#!topic/quarkus-dev/yCGtMdnPMV8

Not sure... I would like to see it in quarkus - we also don't have e.g. TomEE or WebSphere integration code in the myfaces repo

looks good for me @volosied @melloware can you also give a look plz?

in general RestoreViewPhase should be skipped on a GET request, right?

i dont have time to provide a PR or example but the following IF is/was missing in Mojarra: https://github.com/apache/myfaces/blob/c891d43c7740dd40c206b0638d23a11b69a0d441/api/src/main/java/jakarta/faces/component/UIData.java#L383 https://github.com/apache/myfaces/blob/c891d43c7740dd40c206b0638d23a11b69a0d441/api/src/main/java/jakarta/faces/component/UIData.java#L393

it could be that it was fixed with this https://github.com/eclipse-ee4j/mojarra/pull/4506/files but i didnt verify it

i can just say that it requires a lot of work and also changes on existing JSF impl code IMO it would be cool if you guys would do it...

In short: Quarkus is not fully CDI compatible some features are comopletely not supported (like e.g. injection in a non-cdi bean), something like Extensions must be completely rewritten in Quarkus...

You can just check our quarkus extensions: https://github.com/apache/myfaces/tree/main/extensions/quarkus as i said, in addition to make this extension possible, it was needed to refactor some of the JSF Impl code.