Thomas Andraschko

Results 342 comments of Thomas Andraschko

we should chat about it there are more things to do

+1 but we should look now how we can improve performance there - i'm sure it's one of the most used classes in a AngularFaces app, right? As i said,...

FYI caching isn't bad but... 1) use concurrent collections instead of synchronized blocks 2) classloader problems if e.g. AngularFaces is added via tomcat\lib

hmmm a good way would be to provide this caching via an AppScoped bean + concurrent collections

ok caching the method here is ok from classloader perspective - you should just mention somewhere in the docu that AngularFaces should be added the same way as PrimeFaces (tomcat\lib...

@struberg could also review this one?

In general i wonder why dont you contribute directly to DeltaSpike?

looks very good to me! @struberg can we merge it?

Not sure if both projects are interessing in such a shared codebase. Couldnt we reuse beanutils here? cc @struberg

Can you please add a JIRA ticket before (with some description)?