python-console-snake icon indicating copy to clipboard operation
python-console-snake copied to clipboard

Consider using flake8, pylint or black

Open bittner opened this issue 5 years ago • 1 comments

The code base is nice and small enough to run QA tools over it to enforce code quality without a lot of pain. I suggest you try out flake8, pylint or black.

Flake8 is somewhat the standard option (and arguably the minimum requirement), and luckily there is not a lot for you to do to make it pass:

$ flake8 
./menu.py:11:23: E999 SyntaxError: invalid syntax
./menu.py:13:1: E302 expected 2 blank lines, found 1
./menu.py:56:80: E501 line too long (100 > 79 characters)
./menu.py:64:17: E125 continuation line with same indent as next logical line
./menu.py:74:1: E302 expected 2 blank lines, found 1
./menu.py:81:1: E305 expected 2 blank lines after class or function definition, found 1
./menu.py:81:6: W292 no newline at end of file
./snake/__main__.py:26:1: E305 expected 2 blank lines after class or function definition, found 1
./snake/console.py:17:9: E722 do not use bare 'except'
./snake/console.py:27:9: E722 do not use bare 'except'
./snake/graphics.py:38:14: F821 undefined name 'xrange'
./snake/run.py:11:27: E999 SyntaxError: invalid syntax
./snake/run.py:25:1: E305 expected 2 blank lines after class or function definition, found 1
./snake/themes.py:4:1: E265 block comment should start with '# '
./snake/themes.py:5:1: E265 block comment should start with '# '
./snake/themes.py:6:1: E265 block comment should start with '# '
./snake/themes.py:7:1: E265 block comment should start with '# '
./snake/themes.py:8:1: E265 block comment should start with '# '
./snake/themes.py:9:1: E265 block comment should start with '# '
./snake/themes.py:10:1: E265 block comment should start with '# '
./snake/themes.py:11:1: E265 block comment should start with '# '

bittner avatar Oct 28 '18 13:10 bittner

Thanks to your guidance, I created a pull request resolving these alerts. #26

gmaciascorrea avatar May 09 '22 22:05 gmaciascorrea