fantasticon icon indicating copy to clipboard operation
fantasticon copied to clipboard

Possible incorrect scss and sass font family

Open RyanBerliner opened this issue 3 years ago • 1 comments

I am not too familiar with this project, so apologies if I have a misunderstanding here.

I believe the font family declaration in the SCSS and SASS templates should be referencing the appropriate variables instead of the original font name. For example in this file font-family: {{ name }} !important; would need to be changed to font-family: ${{ name }}-font !important;

RyanBerliner avatar Aug 13 '21 02:08 RyanBerliner

Ah - I was thinking that the font variable was defined with a !default flag to allow users to override it. Would you consider a change to the variable declarations to allow user override? If not, feel free to close this, my mistake!

RyanBerliner avatar Aug 13 '21 11:08 RyanBerliner