python-tidal icon indicating copy to clipboard operation
python-tidal copied to clipboard

Increase limit for user.favorites.tracks

Open dmitry-ee opened this issue 4 years ago • 1 comments

I've encountered problem when was working on favorites library export. user.favorites.tracks() method returned only 999 tracks instead of maximal possible amount (5000+). So i made quiet simple workaround fix for that. Hope it looks good

dmitry-ee avatar Jul 17 '20 08:07 dmitry-ee

The request method already supports changing the limit, which you can see below, you call a dict to the param https://github.com/tamland/python-tidal/blob/251ed480cb8ba33eeec16436593e409c49540122/tidalapi/init.py#L186-L187

Also, we probably shouldn't be asking for the max amount of items every time, in 0.7 i have offsets and limits for most of the methods, which is a nicer way to do it, especially in GUIs

This is one of the reasons i don't want PR's right now, i would rather spend my time finishing 0.7 instead of commenting on PR's, and any change i do would make rebasing slightly harder.

Anyway, the 999 limit was added because it didn't work without it before, thanks for letting me know that the limit isn't there anymore, my guess is that it was tied to an api key we used before. Also, the limit seems to be 10000.

Even if you fix the minor issues i probably won't be merging it right now, as you can add git repos to setuptools requirements if you want to.

morguldir avatar Jul 17 '20 23:07 morguldir