tamland
Artist.get_albums_ep_singles() returns empty list
Currently I try to get all albums of this artist https://tidal.com/browse/artist/3538682 (Blumentopf).
If I use Artist.get_albums() it returns only 4 albums (#Hmlr, 'B-Seiten und Raritäten', 'Gern geschehen', 'Großes Kino'), despite there are actually 11:
If I use Artist.get_albums_ep_singles() the result is an empty list. Here I expect to retrieve all albums, EPs and singles. Would this actually even be possible with this filter? Seems like it would leave out the albums, wouldn't it? https://github.com/tamland/python-tidal/blob/6fb5289b698fe40974abf19c0f283b787526ad97/tidalapi/artist.py#L135
What am I doing wrong?
despite there are actually 11
That's odd, I would've expected the call to get_albums() to return all albums with no filtering. Have you noticed the pattern with any other artists?
get_albums_ep_singles()
Yes, this will only return EPs and singles as stated in the function description.
Wouldn't it make more sense, to name it like
get_eps_singles()?
I see your point but since it does return album objects, I think this should still be reflected in the name. So I'd say the naming picked makes sense, although slightly confusing.
I'd be weary with changing the naming of it, in case any external libraries depend on it.
Still doesn't answer why you don't get all albums. If it is a bug, it must occur with other authors as well.
Wouldn't it make more sense, to name it like
get_eps_singles()?I see your point but since it does return album objects, I think this should still be reflected in the name. So I'd say the naming picked makes sense, although slightly confusing.
Usually one reflect this with types (typing). To reflect return types in the name declaration is usual, e.g. for C code but not for Python. In the end, you will decide, but my point is simply, that this is very confusing, since other names do not reflect the return type within this library.
I'd be weary with changing the naming of it, in case any external libraries depend on it.
This would not be the first time, that breaking changes occur. Just kidding :-) Do not get me serious on this.
Still doesn't answer why you don't get all albums. If it is a bug, it must occur with other authors as well.
I could not observe the same behavior with other artists, so far. Only tested it with 20 artists, yet. But what I can say is, that for some artists some albums are returned as duplicates (up to three times). Is this because of different sound qualities or something? Could you already observe such behavior?
since other names do not reflect the return type within this library.
Yes, agreed. Perhaps it would be wise to look through tidalapi and check if there are any other functions with similar confusing / inconsistent names. Let's create a separate issue for these changes. Maybe other developers has opinions on this.
Do not get me serious on this.
Of course, I know what you mean... Of course breaking changes happen but I'd like to create the least inconvenience. 😂
But what I can say is, that for some artists some albums are returned as duplicates (up to three times). Is this because of different sound qualities or something?
Exactly, these are albums in various audio types (eg. SONY360). I noticed the same thing when browsing albums through mopidy. I'd like to make it easier to filter these albums.
Let's look out for other artists where similar issues occur. I'd like to see if we can find an example where the ep_singles actually return something.
I will keep my eyes open and report here, if I can find other examples of this behavior.
I have also created a new issue regarding the naming: https://github.com/tamland/python-tidal/issues/246