python-tidal icon indicating copy to clipboard operation
python-tidal copied to clipboard

Run tests in CI

Open 2e0byo opened this issue 2 years ago • 4 comments

As something of a priority we need to fix the test suite, ideally before we merge anything else. I'll try to get on this this week, unless anyone else wants to.

Once it passes we should add vcr (pytest-recording) with sanitising and run it in ci.

FWIW I think 3.9 is probably broken, but we need tests running in ci to be confident.

2e0byo avatar Jul 10 '23 17:07 2e0byo

I agree. Feel free to take a look at it, as you are definitely the most qualified! ;)

tehkillerbee avatar Jul 11 '23 07:07 tehkillerbee

Tests now pass. We should run in vcr with pytest-recording, but for now lets not merge anything unless one of the maintainers has run the test suite locally.

I've not fixed tox as I don't like keeping the deps in two places, so poetry run pytest. Credentials will be cached locally.

2e0byo avatar Jul 12 '23 22:07 2e0byo

PS didn't add pytest-recording as it's currently broken. There's an open (abandoned) PR to work against latest VCR which would fix it; might pick that up if nobody else does.

2e0byo avatar Jul 12 '23 22:07 2e0byo

Most of the work to get tests running in ci is floating around in a branch on my fork. If someone has the time feel free to get it working: we need to mock the right properties on Session() (or modify it) so we can start a session up without the internet, but all the rest works as recorded. I'm not likely to have much time for this in the next few weeks, but I'll get on it if I can.

2e0byo avatar Aug 21 '23 18:08 2e0byo