pokeget-rs icon indicating copy to clipboard operation
pokeget-rs copied to clipboard

Minior's core form shiny sprite is highly inaccurate

Open OpenSauce04 opened this issue 1 year ago • 4 comments
trafficstars

When attempting to show Minior's shiny sprite, the same colour as the non-shiny version is shown with different shading instead of the expected black core:

OpenSauce04 avatar Jun 19 '24 13:06 OpenSauce04

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

OpenSauce04 avatar Jun 19 '24 13:06 OpenSauce04

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

No idea, but if that's the case then it'll be almost impossible to fix on the pokeget side, since it's not worth forking the whole repo to fix a bug. For now, it'll probably have to be stuck like this, but when they fix it i'll be able to pull the changes into pokeget.

talwat avatar Jun 20 '24 21:06 talwat

In the meantime I have discovered that you can still get the correct sprite by typing out the full correct file name, which works in my case because I'm running from a script.

OpenSauce04 avatar Jun 20 '24 22:06 OpenSauce04

Yeah, I made pokeget pretty flexible when it comes to how you're actually picking the sprites, so for scripts it should work fine :)

I'll keep this open to remind myself to fix this issue.

talwat avatar Jun 21 '24 08:06 talwat

Merging into https://github.com/talwat/pokeget-rs/issues/22.

talwat avatar Mar 20 '25 13:03 talwat