rn-secure-storage icon indicating copy to clipboard operation
rn-secure-storage copied to clipboard

Obsolete build.gradle

Open lorenzogatti opened this issue 2 years ago • 7 comments

Compiling a React Native app for Android with Windows 10, Gradle 7.2, OpenJDK 11.

Gradle 7.2 doesn't like rn-secure-storage\android\build.gradle:

Could not get unknown property 'compile' for configuration container of type org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.

Offending code:

task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

Property "compile" is deprecated since Gradle 6 and removed since Gradle 7 and it has been replaced by "implementation". This works:

task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.implementation
    into 'libs'
}

lorenzogatti avatar Mar 23 '22 15:03 lorenzogatti

Thank you, iruAiweapps! Any chance of an updated release on npm? This library seems a bit abandoned.

lorenzogatti avatar Apr 26 '22 10:04 lorenzogatti

Any idea on when this will be released? Currently, I'm having to manually update the build.gradle file each time I run a yarn add command.

corlissc avatar May 27 '22 14:05 corlissc

Please update the library. Fix one line, it's not hard. Your library is good, but getting into the sources every time is very annoying It is not necessary to release a new major version, you can roll out rc- patch

coprocoder avatar Aug 04 '22 08:08 coprocoder

Please merge Pull Request https://github.com/talut/rn-secure-storage/pull/68

corlissc avatar Aug 04 '22 16:08 corlissc

@coprocoder plz use this https://www.npmjs.com/package/patch-package

affansk avatar Sep 05 '22 21:09 affansk

will crash for release build if we change from configurations.compile to from configurations.implementation

minaGergess avatar Sep 08 '22 12:09 minaGergess

Up :)

AlixH avatar Sep 23 '22 11:09 AlixH

Please check v2.0.8

talut avatar Dec 09 '22 15:12 talut