Tim Allclair

Results 147 comments of Tim Allclair

Thanks! BTW, you don't need to specify the tests to rerun. You can just use `/retest` to rerun all the failed tests. /lgtm /approve

Yeah. @esotsal can you add backoff checking to `TestHandlePodResourcesResize`? https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_test.go#L2580

Copying comment to here for visibility: > The patch needs to go to the `/resize` subresource now. If you're trying to test with kubectl, you'll need to build the binary...

Here's your unit test: https://github.com/tallclair/kubernetes/commit/5533df5385daee246246aa9abc9ec991268b6a3d Please cherrypick that into your PR so we can unblock this.

/test pull-e2e-gci-gce-alpha-enabled-default /test pull-kubernetes-e2e-gce

I decided to just add the auxilary pages to this PR. /assign @sftim