async-techniques-python-course icon indicating copy to clipboard operation
async-techniques-python-course copied to clipboard
verified publisher icon talkpython

Possibly remove `cchardet` dependency?

Open serixscorpio opened this issue 3 years ago • 1 comments

aiohttp stopped installing cchardet speedup under >Python 3.9 (See https://github.com/aio-libs/aiohttp/pull/6857) due to cchardet being unmaintained. I ran async_scrape/program.py successfully without cchardet using python 3.9 and 3.10. I'll send a PR if it makes sense to remove cchardet from the requirements.txt.

https://github.com/talkpython/async-techniques-python-course/blob/dddaba4e13665c27002f1ee79f17914caab5cd99/src/04-asyncio/web_scraping/async_scrape/requirements.txt#L5

serixscorpio avatar Oct 06 '22 04:10 serixscorpio

Thanks for the heads up. Yes, send me a PR and I'll gladly accept it.

mikeckennedy avatar Dec 05 '22 18:12 mikeckennedy