Tal Einat
Tal Einat
I just ran into a case where this could have been used. Unpacking the arguments in other ways is simple and readable enough that I don't think adding this is...
Lars, a huge +1 from me for your suggested approach and patch. I'd like to work this into a review-ready PR. The patch is a great step forward but still...
For one thing, the new diffs are still missing tests. Tests should include, at the least: 1. \*Safely* testing SafeTarFile against examples of problematic tarballs. Perhaps from Jakub's collection of...
I am not a lawyer, but to the best of my understanding, using such tarballs would be fine. Since Jakub's repo only provides code to generate archive files but doesn't...
shashank, you're making good progress on this! The tests should also put SafeTarFile through all of the tests for TarFile, considering that it is being described as a drop-in replacement....
> Having said that, I am refactoring the tests right now since the test file is \~3000 lines and adding SafeTarFile tests for every TarFile test is cluttering it. This...
FWIW, for my use case (properly installing "Celery[sqs]"), it would be fine if the output of pip-compile would include all of the required sub-dependencies without the extras.
The only difference between options 1 and 2 suggested by @AndydeCleyre is whether to add `--include-extras`. It seems to me that there are use cases where it would be useful...
> Because that's the only way to properly represent the exception & the traceback in serialized form, I think. Might want to take a look at [tblib](https://pypi.org/project/tblib/), which can (de)serialize...
I've just run into this as well. Here's a hacky workaround: ```python def get_kubernetes_ws_client_returncode(ws_client: WSClient) -> None | int | str: """Workaround for broken WSClient.returncode property.""" # This is a...