react-native-countdown-component icon indicating copy to clipboard operation
react-native-countdown-component copied to clipboard

fix until does not update when state.property is changed , stays one state behind.

Open pwliuab opened this issue 3 years ago • 2 comments

fix until does not update when state.property is changed , stays one state behind.

  • adding !this.state.isStartedCountDown and this.props.until !== this.preState.until in componentDidUpdate to check intial update
  • one state behind that's because this.props.until == this.preProp.until is always true, intially.

pwliuab avatar Apr 02 '22 06:04 pwliuab

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

rayyanekaputra avatar May 19 '22 18:05 rayyanekaputra

im new, how do you pull this as an import CountDown from 'react-native-countdown-component'; ? or do i need to reinstall the whole library but with your branch? how do i achieve that? thank youu

you can first import the original countdown. Then, you go to the node modules of the original version. Find out the 'react-native-countdown-component' Then, take a look to my pull request, see what is added, you can fix it by adding my changes manually.

pwliuab avatar May 20 '22 03:05 pwliuab