rust-teos icon indicating copy to clipboard operation
rust-teos copied to clipboard

Replace UUID with locator

Open aruokhai opened this issue 2 years ago • 5 comments

Objective Ensure locators are returned instead of uuid's under appointments section when user details are fetched through the cli using the getuser command.

Problem locator is an appropriate identifier for appointments in the Bolt13 specification draft, which is also being used in the getappointments cli command , but in the getuser cli command uuid is being used which can be confusing . The solution is ensure getuser cli command makes use of locator and not uuid.

Changes

  • Modified internal.rs get_user_info function to make use of locator and not uuid when returning user appointments info.
  • Modified internal.rs get_user test to reflect the change from uuid to locator.

Scope Of Change This is a non critical change, as it only affects the CLI.

closes #229

aruokhai avatar Sep 04 '23 22:09 aruokhai

@aruokhai thanks for looking at this. This is going to make much more sense after merging #190, which gets rid of all in-memory data for the tower. Hence, a big refactor will be needed, but it would make the change way smaller. I'd suggest you wait until that is landed and take another look at it.

sr-gi avatar Sep 14 '23 14:09 sr-gi

@aruokhai we just landed #190

sr-gi avatar Sep 14 '23 20:09 sr-gi

would take a look at it again and start working on a new fix

aruokhai avatar Sep 18 '23 12:09 aruokhai

added the necessary changes

aruokhai avatar Dec 15 '23 20:12 aruokhai

Looks like this may be mergeable (?). Planing to give it a last look and merge if so. Needs rebase now that everything is green again

sr-gi avatar Sep 05 '24 21:09 sr-gi