rust-teos icon indicating copy to clipboard operation
rust-teos copied to clipboard

retrier::tests::test_manage_retry_unreachable may randomly fail

Open sr-gi opened this issue 2 years ago • 3 comments

I haven't seen retrier tests randomly failing much lately, but yesterday I got this one:

https://github.com/talaia-labs/rust-teos/actions/runs/5448919099/jobs/9979994482?pr=225

Tracking this to keep an eye on it.

sr-gi avatar Jul 07 '23 15:07 sr-gi

Another timing? failure but in retrier::tests::test_manage_retry_while_idle: https://github.com/talaia-labs/rust-teos/actions/runs/5659276199/job/15332471299?pr=233

mariocynicys avatar Jul 25 '23 16:07 mariocynicys

Looks like it. I hate timing-based tests :/

sr-gi avatar Jul 26 '23 14:07 sr-gi

Locally I've also been getting a test_manage_retry_while_idle failure, looks like at this line: https://github.com/talaia-labs/rust-teos/blob/997f77f69541d96d64e2e7958e5bd4a7049b6efd/watchtower-plugin/src/retrier.rs#L1243

Maybe it'd be worth doing a loop, trying the same call every second or so, either until it succeeds or times out (with a longer timeout than it currently has)

orbitalturtle avatar Mar 30 '24 17:03 orbitalturtle