kuromoji.js icon indicating copy to clipboard operation
kuromoji.js copied to clipboard

[WIP] Migrate to TypeScript

Open takuyaa opened this issue 5 years ago • 6 comments

takuyaa avatar Nov 05 '18 11:11 takuyaa

Waiting for this release

chigix avatar Nov 27 '19 19:11 chigix

When will this be merged and released?

ghost avatar Nov 29 '19 08:11 ghost

@chigix @subs1da I would like to know why you want this. This is not a kind of function, so there is no user's merit. Could you explain your situation or needs?

takuyaa avatar Nov 30 '19 05:11 takuyaa

@takuyaa TypeScript implementation is attractive. If there could be typescript base code, morphological analyzing could become available for both nodejs and browser usage and building, though it might be still not be covered in the goal of current development.

In addition, I'm using Angular, which is a pioneer project employing TypeScript among the most famous modern frontend solution frameworks. Because there is no sophisticated JavaScript implementation especially for the usage within TypeScript, I have to do Japanese texts parsing and analysis with Server API implementation -- now I'm using the Kuromoji implementation integrated in Elasticsearch, which is actually not good on the view of the cohesion inside one feature development and integration.

chigix avatar Nov 30 '19 09:11 chigix

@takuyaa I can not speak for others but I would like to send a new pull request and would like to contribute based on this typescript source code rather than trying to send a javascript pull request that needs to be heavily rebased at another time.

martinheidegger avatar Aug 12 '20 15:08 martinheidegger

This is not a kind of function, so there is no user's merit.

The users benefit from using software that is free of bugs and regularly updated.

In some ways, static typechecking with TypeScript is just like having unit tests. It catches bugs (like null exceptions, "undefined is not a function" errors etc.) and lets developers refactor and write new features faster.

justinsilvestre avatar Sep 24 '20 09:09 justinsilvestre