jitsi-meet-helm icon indicating copy to clipboard operation
jitsi-meet-helm copied to clipboard

template syntax of config files not compatible to current Helm3 - what is this?

Open uvwild opened this issue 4 years ago • 2 comments

Is it intended to put a templated config into the prosody configmap? and which template language is that then? not helm template is it? it does not have tobool

Also I do find the base64 encoded files and some uncommented code

lifecycle:

      #   postStart:
      #     exec:
      #       command:
      #         - /bin/bash
      #         - -c
      #         - cat /var/app/prosody.cfg.lua | base64 -d > /defaults/prosody.cfg.lua
      #         - cat /var/app/jitsi-meet.cfg.lua | base64 -d > /defaults/conf.d/jitsi-meet.cfg.lua
      #         # {{ if .Values.prosody.auth.enabled }}
      #         # - prosodyctl --config /config/prosody.cfg.lua register me $XMPP_DOMAIN $JVB_AUTH_PASSWORD;
      #         # {{ end }}

Did this ever work? If not please add a comment. Its so deeply in the logic that its simply not fair to leave this uncommented for others to run against a wall. Thats the beauti of READMEs.

uvwild avatar Jan 14 '21 01:01 uvwild

Hello,

Talking about the usefulness of a README, have you checked the « warnings » section?

It states how it has been tested + the fact that it’s an experiment.

The mount of the config wasn’t needed after experimenting.

if you noticed incompatibilities with Helm3, feel free to open a PR for updating what doesn’t work for you or be more specific in what prevents you to use it and I will look into it.

taktakpeops avatar Jan 14 '21 06:01 taktakpeops

And yes, the config files aren't supposed to be parsed / interpreted by Helm. They are made for the templating engine of Jitsi.

Mounting these config files wasn't necessary because most values can be overridden using the environment (.Env.MyVar will be replaced at runtime with the value of MyVar defined in the environment).

taktakpeops avatar Jan 14 '21 06:01 taktakpeops