bash_kernel icon indicating copy to clipboard operation
bash_kernel copied to clipboard

Published 20 hours ago • verified publisher icon takluyver

fix pexpect usage

Open zimbatm opened this issue 6 years ago • 1 comments

pexpect wasn't finding the right prompt match and the kernel would then timeout on the jupyter side and get killed.

zimbatm avatar Nov 22 '17 01:11 zimbatm

ping?

zimbatm avatar Jan 21 '21 10:01 zimbatm

I've recently taken on co-maintaining bash_kernel, and I'm currently closing all old/stale issues and PRs.

I'm closing this PR, as reading the diff I can't discern the purpose. Does the issue you were trying to solve persist with the latest version of bash_kernel? Please feel free to reopen this PR if it is still needed for you.

kdm9 avatar Aug 24 '22 10:08 kdm9

it's been a while, but see the commit message:

pexpect wasn't finding the right prompt match and the kernel would then
timeout on the jupyter side and get killed.

Use `bash --login` and assume that it's immediately there instead of
waiting for the first prompt.

Pass the unformatted `prompt_change` to the parent class as it's going
to take care of the formatting by itself. This will make it more
resitant to changes in expect.

I'm not using bash_kernel anymore so won't pursue this

zimbatm avatar Aug 24 '22 10:08 zimbatm