Takahiro Menju

Results 614 comments of Takahiro Menju

Thanks. I'm thinking of removing TestTaskSkipEventsServiceProvider and isTestSkipped. Consistency is more important, and I don't think the copy operation is that heavy of a task. What do you think about...

I'll make a PR to check integration tests → https://github.com/takahirom/roborazzi/pull/366

The reason why the test fails is that when the test fails, testTask.doLast{} is not executed, so intermediateDir is not updated. ``` @Test fun verifyAndRecord_changeDetect() { RoborazziGradleProject(testProjectDir).apply { record() val...

@lukas-mercari I think it is better to merge this fix, but we aren't able to reproduce the problem in our repository. Could you take a look?

@lukas-mercari Thanks. I saw a similar issue. Are you running a single variant? https://github.com/takahirom/roborazzi/issues/377#issuecomment-2130691611

@lukas-mercari If your hypothesis is correct, we might have to check if it is the root suite. Are you seeing multiple 'Roborazzi: test.doLast Copy files' logs? https://stackoverflow.com/a/68518970

In any case, we might need to include this if statement. https://github.com/search?q=%22suite.parent+%3D%3D+null%22&ref=opensearch&type=code

@lukas-mercari Could you please take a look at this PR? https://github.com/takahirom/roborazzi/pull/385/files