Jimmy Jia

Results 391 comments of Jimmy Jia

Why would collapsing events with rAF make the problem worse? And you say this only happens if you have a scrollable element inside a not-otherwise-scrollable window?

I don't really know, sorry. Can you explain your reasoning why `requestAnimationFrame` would make things worse? It seems strictly better to defer the work – and note the use of...

I'm not seeing this on the Figma search on my phone. Note also that we're not setting scroll position in the `_saveWindowPosition` callback. We're just saving the current position to...

Not seeing it on my iPhone X: https://streamable.com/fb7me. In any event, I'm happy to leave this issue open for you or others to further pursue what's happening, but I'm not...

Oh, interesting. Yeah, that's a gap. I'd be happy to take a PR here.

That's a good catch. The issue here is that the initial location doesn't get supplemented with a randomly-generated key, as we didn't want to trigger an immediate navigation action on...

That's not quite the same, though. To emulate native browser scroll behavior, you _do_ want to preserve scroll position if someone reloads the page.

And to be clear, we do still attach keys on navigation to locations _after_ the first. But we don't do this for the first location because it would require triggering...

Farce adds unique keys to all locations that _it_ generates. However, for the initial page load, I'm not aware of a way to update the location state. Old versions of...

I honestly can't remember any more. It was enough that they took it out in history v4, though.