Jimmy Jia

Results 401 comments of Jimmy Jia

@react-bootstrap/collaborators thoughts?

Makes sense. We'll follow the upstream here – will watch the PR there.

Are you thinking a functional child thing? Or maybe just helpers and/or hooks to calculate the merged class name from some sort of config object?

I don't think we want to always recalculate the popper position on content changes, as that could be quite expensive, and most changes won't reposition the menu. @jquense does it...

Weird. Would you be able to check if this happens with just plain Bootstrap JavaScript? i.e. is this a React-Bootstrap bug, or does this happen upstream as well?

Right, so on the utility classes, I think those are intentionally unprefixed. The `bsPrefix` support is on e.g. changing `form` to `my-form`, but e.g. `show` is the same everywhere. As...

We do still want the `animation` boolean prop to work, though. That said I wouldn't be opposed to also allow customizing the transitions here. @jquense wdyt?