Jimmy Jia comments

Results 401 comments of


                                            Jimmy Jia

Show more information on assert_response when status code fails

yeah we should hook into some better formatting here

Allow passing a schema class instead of schema instances

Somewhat related to https://github.com/4Catalyzer/flask-resty/issues/238. I guess I was thinking that individual views might want to pass things into schema constructors, but that's never really happened. Though, in practice, in a...

Allow passing a schema class instead of schema instances

@itajaja is saying that if you have separate instances, then you would in fact be able to set `context` on them normally.

pagination doesn't return total page number or total query number

It might make sense to add this as an extension or mixin. We don't do this by default because evaluating this sort of `COUNT(*)` requires at least doing an index-only...

pagination doesn't return total page number or total query number

Yeah, that looks pretty good. I think maybe we want to make this an option for the relevant pagination components. You can see that e.g. this requires another database query...

pagination doesn't return total page number or total query number

Yeah, that makes sense. What do you think of PRing this as an optional thing in our pagination classes?

Figure out a better way to manage "current view" context

yes, but that wouldn't let you do e.g. `OtherView().query`

Figure out a better way to manage "current view" context

it works better if those are all classes, note. otherwise we'd be mutating objects or doing other magical things.

Figure out a better way to manage "current view" context

i'd call it `Authorization` to make inline defs a bit nicer-looking – `class Authorization(FooView.Authorization)` reads better than `class authorization_class(FooView.authorization_class)`. we could take the same approach more broadly, though, e.g. with...

feat: Add an upsert_item method

I don't think this is the right way to go. I think we might want more of a `update_item_some_more_raw` hook that both `update_item_raw` and `create_item_raw` call.