tailwindcss-typography icon indicating copy to clipboard operation
tailwindcss-typography copied to clipboard

Bring back "Adding new modifiers" section to README.md

Open lekterable opened this issue 1 year ago • 2 comments

Changes made to README.md have first removed and then brought code bits to README, but "Adding new modifiers" section was lost somewhere along the way,

I find it pretty important as it encourages customization + it also broke one answer to an old issue which actually lead me here: https://github.com/tailwindlabs/tailwindcss-typography/issues/52#issuecomment-769755342

I simply propose to bring it back

lekterable avatar Jun 26 '24 22:06 lekterable

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-typography ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 10:33pm

vercel[bot] avatar Jun 26 '24 22:06 vercel[bot]

Hi @philipp-spiess, sorry for tagging you, but this has been open for some time now and looking at the reaction quite a few people found it important. Do you think we could merge it? Thanks!

lekterable avatar Jun 16 '25 18:06 lekterable

Hey @lekterable! Appreciate the PR and yeah agree that this has been open for too long.

I also don't fully understand how this section is different than that one: https://github.com/tailwindlabs/tailwindcss-typography?tab=readme-ov-file#customizing-the-css It also mentions this at the end:

Customizations should be applied to a specific modifier like DEFAULT or xl, and must be added under the css property.

I guess if we want we could just mention that you can also use this to add new modifiers but I'm not sure how often you'd need that so I'm instead going to say no for now, sorry!

philipp-spiess avatar Sep 18 '25 15:09 philipp-spiess