headlessui
headlessui copied to clipboard
fix(vue): skip deleting portal root node to avoid race condition
Even w/ the latest version of HeaadlessUI for Vue I was running into an issue where if a new dialog starts opening up while a previous dialog is in the process of closing down you can run into an issue where the old dialog starts removing the shared PortalRoot while the new dialog has already chosen to rely on it as its PortalRoot. This then ends up breaking the rendering of the 2nd dialog as it ends up being unmounted from the DOM along with the PortalRoot.
The fix is easy - just skip removing the portal root. I don't see any real benefits for removing it, I mean its just one single empty div node, there's no performance gain to having it be removed, and keeping it around fixes the race condition issue.