headlessui icon indicating copy to clipboard operation
headlessui copied to clipboard

Fix incorrect behavior of `isTyping`

Open velopsey opened this issue 1 year ago • 2 comments

This PR fixes an issue where navigating from one Combobox to another using the Tab key blocked the displayValue from updating in the next render.

The issue was partially introduced in this PR: https://github.com/tailwindlabs/headlessui/pull/3259.

Currently, any interaction with the keyboard activates a mode that prevents the value from being updated.

My fix is a straightforward solution, but as maintainers of this library, you may have a better idea of how to address this bug. I’d be happy to implement any suggestions you provide.

Thank you for your work — this library truly helps make my interfaces better

Fixes: #3595

velopsey avatar Dec 15 '24 18:12 velopsey

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 6:19pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 6:19pm

vercel[bot] avatar Dec 15 '24 18:12 vercel[bot]

@RobinMalfait I’d really appreciate it if you could take a look at this fix. It’s simple and easy to understand, and I’m happy to respond quickly to any questions or feedback. This will genuinely help my company (takeda.com)

velopsey avatar Dec 15 '24 19:12 velopsey

Hey!

Sorry about the delay, but thanks for the PR! The PR was a bit behind, so rebasing wasn't as straight forward. To keep things easy, I opened a new PR (#3785) to solve this issue.

I also added you as a co-author of that PR. Thanks again!

RobinMalfait avatar Sep 05 '25 12:09 RobinMalfait