headlessui icon indicating copy to clipboard operation
headlessui copied to clipboard

Fix `Transition` events order

Open RobinMalfait opened this issue 3 years ago • 2 comments

This PR fixes an issue where the order of {before,after}{Enter,Leave} don't happen at the correct time.

RobinMalfait avatar Jun 13 '22 17:06 RobinMalfait

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ❌ Failed (Inspect) Aug 18, 2022 at 2:20PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 2:20PM (UTC)

vercel[bot] avatar Jun 13 '22 17:06 vercel[bot]

So, so, so much better! I still think the order of the before events should be reversed (out -> in) but I know why they're not in React at least. Can you give this a try with Vue to make sure we match the order in both places (or I can port this if you want). I have a feeling, for some reason, that the order might already be reversed there if you implement this.

thecrypticace avatar Jun 13 '22 18:06 thecrypticace