komiser icon indicating copy to clipboard operation
komiser copied to clipboard

Filters bar & filters' style don't match the design

Open AllieMendes opened this issue 1 year ago • 14 comments

Describe the bug Here is a list of inconsistencies found:

  1. The "Add Filter" button's icon doesn't match the designs and doesn't seem to be using our icon library.

Implementation: image

Figma reference: image

  1. The filters bar has a "Filters" title before the filters that shouldn't be there.

Implementation: image

Figma reference: image

  1. The filter's margins don't follow the ones set on the Figma component; the icon stroke is thinner than it should; the close button doesn't match the design.

Implementation: image

Figma reference: image

  1. The add filter button (after a filter has already been added) is not really a button and doesn't match the one on the Design System.

Implementation: image

Figma reference: image

  1. The divider between the filters and the "Clear filters" button's color doesn't match the design.

Implementation: 0 solid #e5e7eb

Figma reference: image 1px solid #edebee

  1. The "Clear filters" button doesn't match the design — it should be a text button with an icon (the button states are all documented on the Design System).

Implementation: image

Figma reference: image

Additional context If you want to tackle this task, feel free to share with us your email address so we can give you access to the Figma project :)

AllieMendes avatar Sep 05 '23 19:09 AllieMendes

Hey, thank you for opening your first Issue! 🙂 While a Tailwarden team member takes a look at your issue we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com

github-actions[bot] avatar Sep 05 '23 19:09 github-actions[bot]

Hey @AllieMendes I would like to work on this issue. Can you assign it to me?

sajdakabir avatar Sep 26 '23 14:09 sajdakabir

Hey @AllieMendes I would like to work on this issue. Can you assign it to me?

all yours @sajdakabir

mlabouardy avatar Sep 26 '23 15:09 mlabouardy

Hey @mlabouardy Can you please give me Figma assess

sajdakabir avatar Sep 26 '23 19:09 sajdakabir

Hey I've sent an invitation @sajdakabir!

AllieMendes avatar Sep 26 '23 19:09 AllieMendes

@sajdakabir just as a heads-up, we just introduced the dependency-graph which is re-using some of the inventory filters. You can see the changes here. I hope it can be merged soon!

Screenshot 2023-09-27 at 16 52 48

Ping me if you have any questions regarding my changes 🙏

Traxmaxx avatar Sep 27 '23 14:09 Traxmaxx

Hey @AllieMendes, Can you please help me with the below error? Screenshot 2023-09-29 at 11 33 01 PM

To run the server I have flowed https://github.com/tailwarden/komiser/blob/develop/CONTRIBUTING.md#how-can-i-contribute-to-komiser-dashboard .

sajdakabir avatar Sep 29 '23 18:09 sajdakabir

I think you have not started the server, if not please create a config.toml and then in komiser dir run go run *.go start --config="./config.toml". Let me know if this works

AvineshTripathi avatar Sep 29 '23 18:09 AvineshTripathi

After running go run *.go start --config="./config.toml" I am still getting the same error.

Screenshot 2023-09-30 at 12 49 29 PM

sajdakabir avatar Sep 30 '23 07:09 sajdakabir

After running go run *.go start --config="./config.toml" I am still getting the same error.

Screenshot 2023-09-30 at 12 49 29 PM

On which port does your server start? How are you starting the UI? In NEXT_PUBLIC_API_URL=http://localhost:3000 npm run dev, the value of NEXT_PUBLIC_API_URL should be the server url.

Azanul avatar Sep 30 '23 09:09 Azanul

It's working now. Thank you @Azanul and @AvineshTripathi

sajdakabir avatar Sep 30 '23 10:09 sajdakabir

Hey @sajdakabir, any update on this issue? Let me know if you have any questions!

AllieMendes avatar Dec 04 '23 11:12 AllieMendes

Hey @AllieMendes, Please pass it to another one. I am busy with something else.

Thank you.

sajdakabir avatar Dec 04 '23 11:12 sajdakabir

Thank you for the update @sajdakabir! I'll unassign you then

AllieMendes avatar Dec 04 '23 12:12 AllieMendes