tailwarden
Improve all Buttons and update Storybook with all variants
Issue got updated! Previous issue details can be seen below
Fix all Buttons and update Storybook to show all variants correctly (including text buttons, icon buttons & filter button)
Our Button documentation and styling nees to be improved a bit. You can find the Storybook story inside our Storybook and you can find the designs inside Figma.
Please compare Figma styles against the implementation and update both the Button component and Storybook button story accordingly. Please also make sure all options and variants are properly documented in Storybook.
Additional context If you want to tackle this task, feel free to share with us your email address so we can give you access to the Figma project :)
Outdated desciption:
Title: Input stroke is quite big for some reason Describe the bug I noticed on the tags management tab that the input stroke is quite big - the active state is normal. It also happens on views inputs for example, such as the type of alert and details. The search bar on the views sidebar looks normal.
Current implementation screenshots:
Design system component documentation:
Hey @mlabouardy, I would like to work on this. Please assign it to me and refer the file.
Hey @mlabouardy, I would like to work on this. Please assign it to me and refer the file.
all yours :)
Hey @professorabhay, any update on this? let me know if you need any help here with this! it'd be super cool to get this on for the next release 🚀
Hey @ShubhamPalriwala, I'm on it from now. Is there anything you would like to tell me about codebase for the particular problem? Then it will little easy for me to resolve it.
Heyyy, did you get the Figma invite for the designs for a deeper look?
heyy, could you check your email once again, we just sent an invite for figma 🙌🏻
@ShubhamPalriwala, I think that it's not what I can do. I was think that I solve it by learning but it's damn hard and confusing. So, I want to unassigne me from this !
Hey @professorabhay, are you sure? If we can help in anyway to make it easier for you, please let us know. We would be more than happy to help you here! 🙌🏼 If you still prefer to not work on this currently, do let me know and I'd unassign it for somebody else to take it up or for you to maybe come back later when you feel so!
Thanks @ShubhamPalriwala, But for now, I would like to unassign me from this.
no issues, at all, done! this issue back open for anybody who's interested!
Hello, I wish to start contributing in Komiser. I believe I can solve this issue, so can someone assign this issue to me
Hello, I wish to start contributing in Komiser. I believe I can solve this issue, so can someone assign this issue to me
done :)
Thanks @mlabouardy . can you also give me access to the Figma file? My email id is [email protected]
Thanks @mlabouardy . can you also give me access to the Figma file? My email id is [email protected]
Done, I've sent you an invite
I have tried to fix the input stroke. I was not able to find the design component in Figma. @mlabouardy mentioned the input field of search bar on the views sidebar looked normal. So I took that as reference.
Earlier the outline of input element was more, so I have reduced the pixels there.
Can anyone comment if it is fine to raise the PR with this?
Normal State
Input Focused State
Hello! I'm a Product Designer at Tailwarden and I've joined Github to provide support to tickets like this The stroke is indeed the same for any input component on Komiser, so from what I can tell your solution works You can raise a PR for this @Manish4044, thank you
I updated the issue with the latest findings on what to improve around buttons. We now would like to fix all styling issues while also updating the Storybook story with all missing variants and properties!
