komiser
komiser copied to clipboard
tailwarden
[FEAT-1236] Add Card Variants to Storybook
Fixes: #1236
Changes Made
- Add stories for card
- Created Components to match Figma
- Added tests
Screenshots
Checklist
- [x] Code follows the contributing guidelines
- [x] Changes have been thoroughly tested
- [x] Documentation has been updated, if necessary
- [ ] Any dependencies have been added to the project, if necessary
Reviewers
@[username of the reviewer]
A little unclear about these props ( pill, size, state )
@AllieMendes can you help me with this?
A little unclear about these props ( pill, size, state )
@AllieMendes can you help me with this?
Sorry for the delay @ManishBisht777, didn't see this.
The pill is a toggleable element, I recommend using the Dev Mode playground to test the components and what each property does:
Here is an example of where it's used:
The size is outdated, it seems, and the hover state is missing (but the property should exist). I'll update the DS with the hover state.
If I take too long to answer, don't hesitate to ping me on Figma as it's easier for me to keep track of the conversation!
A little unclear about these props ( pill, size, state ) @AllieMendes can you help me with this?
Sorry for the delay @ManishBisht777, didn't see this.
The pill is a toggleable element, I recommend using the Dev Mode playground to test the components and what each property does:
Here is an example of where it's used:
The size is outdated, it seems, and the hover state is missing (but the property should exist). I'll update the DS with the hover state.
If I take too long to answer, don't hesitate to ping me on Figma as it's easier for me to keep track of the conversation!
got it, thanks allie🚀
Hey @ManishBisht777 how are we doing here, do you need any help or is this PR waiting for review ?
hey @AvineshTripathi sorry completely forgot about this pr will will get back to in some time, sorry for the delay
