komiser icon indicating copy to clipboard operation
komiser copied to clipboard

Add Banners to Storybook

Open Traxmaxx opened this issue 2 years ago • 6 comments

Add Banners to Storybook so they are properly documented!

Screenshot 2023-11-27 at 13 10 26

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=1872-12554&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README

Traxmaxx avatar Nov 27 '23 12:11 Traxmaxx

Hello, could you kindly assign the issue to me?

knav33n avatar Dec 13 '23 11:12 knav33n

Hey @knav33n! The issue has been assigned, I'll give you access to the Design System on Figma Let me know if you have any questions!

AllieMendes avatar Dec 13 '23 14:12 AllieMendes

Hey @Traxmaxx and @AllieMendes. In Figma, the description suggests that this component is generic, which it doesn't seem to be. I just wanted to clarify whether it is intended to be a generic component or not. Could you also please let me know if everything looks okay? If so, I will proceed to raise a pull request.

komiser-1243

knav33n avatar Jan 13 '24 06:01 knav33n

Hi @knav33n! Yes, the component should be fairly generic, so that the copy and button inside can be changed, along with the color. So in this case, I would say the Komiser stars button should be a component used inside the banner — the banner shouldn't be just for the Komiser stars use case. Let me know if this helps!

AllieMendes avatar Jan 16 '24 12:01 AllieMendes

@knav33n Are you still working on this? Has there been any progress?

Azanul avatar Jul 11 '24 00:07 Azanul

@Azanul apologies for the oversight. I inadvertently lost track of this issue, but I had actually worked on it some time ago. I will prioritize it now and provide you with an update in a few days.

knav33n avatar Jul 16 '24 16:07 knav33n