komiser icon indicating copy to clipboard operation
komiser copied to clipboard

Add datepicker to Storybook

Open Traxmaxx opened this issue 2 years ago • 6 comments

Add datepicker to Storybook so it is properly documented!

Screenshot 2023-11-27 at 13 00 48

https://www.figma.com/file/eq3JgvmW48IVrYcg2kzgLL/Komiser---Design-System?type=design&node-id=1856-12529&mode=dev

You will find a short intro into our Storybook setup in the Dashboard README

Traxmaxx avatar Nov 27 '23 12:11 Traxmaxx

@Traxmaxx assign please.

umrkhn avatar Nov 29 '23 00:11 umrkhn

I've assigned it to you @umrkhn and left a comment on Figma, let me know if you have any questions or suggestions on how we can improve the component!

AllieMendes avatar Nov 29 '23 08:11 AllieMendes

@AllieMendes I couldn't find the code related to the date-picker component can you guide me ?

umrkhn avatar Nov 30 '23 14:11 umrkhn

I believe the component doesn't exist, it must be created and added to storybook Can you please confirm @Traxmaxx?

AllieMendes avatar Nov 30 '23 14:11 AllieMendes

Woops, I didn't check ninitially and presumed it's existing already. Sorry for the confusion. @AllieMendes do you think it makes sense to add it or is the datepicker obsolete for the forseeable future? @umrkhn depending on the answer to aboves question I can create a separate issue for initially creating the datepicker or I update this one to include that task as well and will pull the specs from figma for you.

Traxmaxx avatar Dec 05 '23 18:12 Traxmaxx

Thank you for checking @Traxmaxx. I think it makes sense as there has been this issue for a long time that uses it: https://github.com/tailwarden/komiser/issues/854 The designs are on Figma for the context, so if you want to create the datepicker component @umrkhn we could finally use it on issues like these :)

AllieMendes avatar Dec 06 '23 09:12 AllieMendes