komiser
komiser copied to clipboard
feat: add single dependency graph view for a specific resource relations
Solution
Add a single dependency graph view for a specific resource relations in the inventory tabs
Checklist
- [x] Code follows the contributing guidelines
- [x] Changes have been thoroughly tested
- [ ] Documentation has been updated, if necessary
- [ ] Any dependencies have been added to the project, if necessary
Reviewers
@Traxmaxx
@shavidze Could you resolve the conflicts before we get to the review
- The "open in explorer" link doesn't seem like a link, it acts as text on hover.
- IDK if this is intended behaviour but on opening in explorer the filter option is not available.
- On opening in explorer, only the selected resource and it's relations are on the graph. IMO it should have zoomed in on the resource instead of filtering everything else out. But the current one is also good.
you can see our conversation about this feature here
- The "open in explorer" link doesn't seem like a link, it acts as text on hover.
- IDK if this is intended behaviour but on opening in explorer the filter option is not available.
- On opening in explorer, only the selected resource and it's relations are on the graph. IMO it should have zoomed in on the resource instead of filtering everything else out. But the current one is also good.
you can see our conversation about this feature here
It seems like point 1 and 3 still stand. Regarding 2nd point, I think @AllieMendes meant that there shouldn't be any applied filter but the option should still be available.
@Azanul @AllieMendes
What is the purpose of having a filter there?
We still don't have and can't have a filter that would filter by resource id
.
If we had that, then the user would be able to display all the existing graphs on the dashboard
but now I don't understand why we need these filters in this case.
@AllieMendes correct me if I'm wrong. On opening explorer page from resource, the usual explorer will open up with no filters and all other resources of the given provider. The only thing different would be that the selected resource will be centered and zoomed on.
@AllieMendes correct me if I'm wrong. On opening explorer page from resource, the usual explorer will open up with no filters and all other resources of the given provider. The only thing different would be that the selected resource will be centered and zoomed on.
hmm, Yes you're right, I'm wrong maybe I read the previous Allie's comment, I will update it today
Hey @Azanul can we move forward for this PR?
Hey @Azanul can we move forward for this PR?
Hi, sorry I just left to zoom the actual relations on explore page, otherwise the main functionality is done. Sorry again, I left my prev job and had a several interviews last days, tomorrow I believe I will have a time to update it.
@shavidze no problem. Take all the time you need. Do we know that is still left to be done in this PR? I hope your interviews are going well! 🙏
@shavidze no problem. Take all the time you need. Do we know that is still left to be done in this PR? I hope your interviews are going well! 🙏
Thanks for your understanding, and sorry again.
I updated my PL and merged conflicts, one thing left, when we open the explorer page I'm trying to save the resource-id
in the browser's local storage
, maybe it would be better to handle it with some state but I think local storage would be okay as well, since if we try to pass it in the URL query it messes some things up.
I was trying to get the node with this ID
but it seems it does not work correctly and I don't have enough time to read Cytoscape docs, if someone will help me I would be honored.
@shavidze no problem. Take all the time you need. Do we know that is still left to be done in this PR? I hope your interviews are going well! 🙏
Thanks for your understanding, and sorry again. I updated my PL and merged conflicts, one thing left, when we open the explorer page I'm trying to save the
resource-id
in the browser'slocal storage
, maybe it would be better to handle it with some state but I think local storage would be okay as well, since if we try to pass it in the URL query it messes some things up. I was trying to get the node with thisID
but it seems it does not work correctly and I don't have enough time to read Cytoscape docs, if someone will help me I would be honored.
@Traxmaxx if you got time
Did you have time to take a look @Traxmaxx ?