komiser
komiser copied to clipboard
tailwarden
Add tabs to Inventory sidepanel
Feature description To match the sidepanel we want to introduce on the Resources Explorer page, two tabs need to be introduced on the sidepanel that opens when a user clicks on a resource. The tab 'Resource details' should provide more information on the resource at hand and the tab 'Relations' should showcase the closest relations to that resource on a smaller version of the Explorer, with the option to open the explorer on that particular resource and everything surrounding it.
Resource details tab:
Relations:
Additional context If you want to tackle this task, feel free to share with us your email address so we can give you access to the Figma project :)
Do we have some test accounts for cloud providers to reproduce this? I'm trying to use my current aws account but I can't see these tabs on the side panel just see
Do we have some test accounts for cloud providers to reproduce this? I'm trying to use my current aws account but I can't see these tabs on the side panel just see
The tabs don't exist yet, the ticket is to add those tabs to the side panel, in addition to the existing tags tab you see on your account
@AllieMendes Do we have a design for it ?
@Traxmaxx I need help, What do you think about this dependency graph for some specific resource, should I write a separate API for it? or just filter after handling all the relations?
@shavidze sorry for taking longer to get back to you. The Figma designs are linked above
I was not aware that we do not have an API yet to fetch a single ressource. I think it's a great idea to create an API for that first before continuing this sidepanel issue.
Should we open up a new issue to work on the API separately?
@shavidze btw, we also have a need for this API in #1072 for the dependency graph.
@shavidze let me know your email so I can invite you to Figma so you can check the designs
Last update
My pull request about fetching a single resource is merged, and I'm ready to work on this feature.
@AllieMendes Do we need zoom buttons here, since we have zoom functionality on touch?
@AllieMendes Do we need zoom buttons here, since we have zoom functionality on touch?
I'm not sure I follow, what do you mean we have zoom functionality on touch?
@AllieMendes I mean , for example like it is on explorer page. One more question, so if user clicks the open the explorer we should open on that particular resource and everything surrounding it, but with this logic it will span every resource that is related with the same cloud platform. Maybe I don't understand it right
@AllieMendes I mean , for example like it is on explorer page. One more question, so if user clicks the open the explorer we should open on that particular resource and everything surrounding it, but with this logic it will span every resource that is related with the same cloud platform. Maybe I don't understand it right
Hey @shavidze, regarding your question, if the user clicks on "open the explorer", we should take the user to the Explorer page with a filter "Resource ID is ID of the target resource" (we need to support Resource ID as a filter in the below dropdown menu):
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
We don't introduce filter by resource name, we will support filter by resource id, so we can leverage that case to open single resource relations in the explorer.
But do we really need it? What is the purpose of it? @mlabouardy
According to the designs, we will support filter by resource name — therefore my question
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID
Got it, I'll add it to the Designs then!
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID
Got it, I'll add it to the Designs then!
Do we have some updates?
Since we'll be introducing the filter "Resource name", couldn't we leverage that @mlabouardy? And by opening the explorer, it would be ideal to have no filters on what resources are displayed
we could leverage "resource name" but I'm afraid the name isn't a unique attribute vs resource ID
Got it, I'll add it to the Designs then!
Do we have some updates?
Yes! Sorry for the delay, I was off.
So, for the visible filters, that the user can add, we'll keep the resource name as it wouldn't be intuitive for a user to search manually for a resource ID (and we would need to display it for all of them).
However, since we have access to this resource ID, when the user clicks on "Open in explorer" we can leverage it to point the user to the right area (without a visible filter on the filters bar, as it wouldn't change what's being displayed on screen). The graph should still display all resources but be centered on the resource they were inspecting on the inventory.
Maybe @Traxmaxx can give some insights on how we can work with the positioning without filtering the graph.
@AllieMendes I'm sorry I couldn't work on this task past days, I'll definitely finish it tomorrow, I think everything is clear.