tailscale-android icon indicating copy to clipboard operation
tailscale-android copied to clipboard

Allow the user to control which apps can use the VPN (WIP)

Open vquicksilver opened this issue 3 years ago • 5 comments
trafficstars

This PR allows to control which apps are allowed to connect to the VPN, it adds a new entry to the menu once the user has been connected and display a dialog where the different apps can be enabled/disabled. The user needs to enable/disable the VPN again to apply the changes.

Signed-off-by: Víctor Enríquez [email protected]

vquicksilver avatar Aug 23 '22 22:08 vquicksilver

Attaching mandatory screenshot.

Screenshot_1661294161

vquicksilver avatar Aug 23 '22 22:08 vquicksilver

Disclaimer, the last time I coded anything was back in 2017 and this is the first time I try to do anything in go + gioui, so guidance to make this work properly is absolutely welcomed.

Note that it is working already, though it might still be a little bit clunky.

vquicksilver avatar Aug 23 '22 22:08 vquicksilver

@DentonGentry Extra question, after using the modified app for a week or so, I also realized that probably the option for choosing the apps should be available even if the user hasn't signed it yet, so that it can block certain apps right away if required. Should I also hide that option? (like the one for using a custom server).

Thank you very much for your review! I will try to allocate some time to improve this PR between this week and the next one.

vquicksilver avatar Sep 01 '22 20:09 vquicksilver

I am interested in contributing the necessary changes to this PR. Would the preferable path be to allow write access or create a new branch?

myned avatar Mar 09 '23 23:03 myned

@Myned, you can send a PR from your own fork. That's the typical GitHub workflow. You don't need write access or any permissions.

bradfitz avatar Mar 09 '23 23:03 bradfitz