tailscale-android icon indicating copy to clipboard operation
tailscale-android copied to clipboard

Feature: machine status icon added.

Open aalokkamble opened this issue 1 year ago • 1 comments

added device status icon similar to iOS UI

markup_1000036970

aalokkamble avatar Feb 16 '24 23:02 aalokkamble

@sonovawolf @bradfitz please review.

aalokkamble avatar Feb 16 '24 23:02 aalokkamble

Thanks for working on this. A few issues: -in a tailnet with more than one user "MY DEVICES" distinguishes between your devices and other users' devices. "MACHINES" is unclear. -the size of the dot looks great, but the alignment should be vertically centered to a lowercase letter, since machine names won't have uppercase letters

kari-ts avatar Feb 27 '24 21:02 kari-ts

@kari-ts Hi I have made the changes. Please review.

  • Aligned dot vertically with lowercase letters for machine names.
  • 'Machine' now reverted to 'My Devices'. (This was done to match our website UI)

aalokkamble avatar Feb 28 '24 18:02 aalokkamble

Screenshot_20240228-183143~3.png

Screenshot for reference

aalokkamble avatar Feb 28 '24 18:02 aalokkamble

Hey @aalokkamble, thank you for the changes, now the alignment looks great.

Is it the screenshot or are the dots slightly horizontally squished and not entirely circular?

sonovawolf avatar Mar 04 '24 23:03 sonovawolf

Its just a text - dot char. Circular

aalokkamble avatar Mar 05 '24 09:03 aalokkamble

Ah, I see. That's why it's not a full circle. That also has the added problem of changing the shape with the font… do you mind making it an actual circle? Either via svg or by creating a shape?

sonovawolf avatar Mar 05 '24 20:03 sonovawolf

Screenshot_20240305-211719.png

Now using perfect circle 🙂

aalokkamble avatar Mar 05 '24 21:03 aalokkamble

Great, thank you!

sonovawolf avatar Mar 06 '24 20:03 sonovawolf