github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Update Tailscale default version to 1.66.4

Open evenh opened this issue 2 years ago • 6 comments

I noticed that the default version was out of date, hence this PR.

evenh avatar Oct 26 '23 10:10 evenh

It's 1.66.4 now.

venkatamutyala avatar May 25 '24 19:05 venkatamutyala

Hi @evenh , could you update this to use the latest

jayvdb avatar Jun 08 '24 21:06 jayvdb

Bumped!

evenh avatar Jun 08 '24 23:06 evenh

Does it make sense to configure Renovate to update the version automatically?

Zebradil avatar Jun 09 '24 20:06 Zebradil

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See https://github.com/tailscale/github-action/issues/28#issuecomment-1838519627

evenh avatar Jun 09 '24 22:06 evenh

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See #28 (comment)

I haven't seen the comment you linked before, it seems reasonable to me.

The workaround is quite simple. In our workflows we currently use the following step to connect to the tailnet:

jobs:
  some-job:
    steps:
      - name: 'Tailscale'
        uses: 'tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d' # v2.0.0
        env:
          # See https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions
          # renovate: datasource=github-releases depName=tailscale/tailscale
          TAILSCALE_VERSION: '1.66.4'
        with:
          authkey: '${{ secrets.TAILSCALE_AUTHKEY }}'
          version: '${{ env.TAILSCALE_VERSION }}'

With the following bit in the renovate config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["regexManagers:githubActionsVersions"]
}

The TAILSCALE_VERSION is only needed to use the built-in regexManagers:githubActionsVersions preset. If it is not desirable, one can define their own rule using the Regex Manager to update version in-place.

Zebradil avatar Jun 10 '24 08:06 Zebradil

Looks like this is fixed here on main - https://github.com/tailscale/github-action/pull/112

However would be good if a new release could be created so we don't have to switch to

uses: tailscale/github-action@main

andrewgbell avatar Dec 13 '24 10:12 andrewgbell

Hey folks! Closing this out as the default version has been bumped a few times since this PR. New versions of the action also allow for specifying latest instead of a version number to ensure the action always pulls the latest stable release if that is desired.

mpminardi avatar Jun 12 '25 04:06 mpminardi