github-action icon indicating copy to clipboard operation
github-action copied to clipboard

Allow to use pre-installed binaries

Open borchero opened this issue 1 year ago • 7 comments

Motivation

Potentially, tailscale(d?) have been installed via a separate workflow step to manage the Tailscale version via an external tool (e.g. via conda-forge - tailscale, tailscaled). This change allows tailscale/github-action action to simply use these installed binaries rather than forcing the user to download additional binaries.

borchero avatar May 01 '24 22:05 borchero

I just noticed that this would also solve #56 (and supersede #103) as brew install tailscale can be run in a separate step.

borchero avatar May 03 '24 21:05 borchero

FYI, I tested the latest commit in a personal project and it worked nicely.

borchero avatar May 04 '24 18:05 borchero

@borchero , could you rebase this

jayvdb avatar Jun 08 '24 21:06 jayvdb

@jayvdb sorry for the delay, finally done :smile:

borchero avatar Jun 16 '24 21:06 borchero

ping @knyar & @patrickod & @willnorris

jayvdb avatar Jul 29 '24 03:07 jayvdb

bump, just in case

haron avatar Mar 17 '25 14:03 haron

I'm not really sure what to do to link an already present binary on Windows -- do I need to do anything if it's on the path?

borchero avatar Apr 21 '25 13:04 borchero

@borchero Apologies, the GitHub action has since migrated to a JavaScript implementation. If you're willing to submit a new PR against that, we'll review it.

One thing I would recommend changing is to just allow specifying the path to the binaries directly as parameters to the action, that way it doesn't matter if they're on the PATH or not. So instead of a download parameter you would have two parameters, existingTailscalePath and existingTailscaledPath or something like that.

oxtoacart avatar Oct 20 '25 17:10 oxtoacart