codespace icon indicating copy to clipboard operation
codespace copied to clipboard

Does not support non-x64 architectures

Open maxlyth opened this issue 6 months ago • 0 comments

While this plug-in does work on my M1 MacBook I noticed that is was being executed by Rosetta inside the ARM64 container as this extract from ps demonstrates: /run/rosetta/rosetta /usr/local/sbin/tailscaled

Looking at the source code I can see the download URL in src/tailscale/install.sh is hardwired to the amd64 release: tailscale_url="https://pkgs.tailscale.com/stable/tailscale_${VERSION}_amd64.tgz"

The source website has binaries for arm, arm64, mips and many more so this project could install the correct binary. I believe the plug-in used to build from source but was modified in July 22 in this pull to download precompiled binaries making that pull request a regression.

I can see that there is an outstanding pull request that would fix this issue at least for Linux on ARM64. Can this be merged to the release branch please?

maxlyth avatar Aug 16 '24 16:08 maxlyth