caddy-tailscale icon indicating copy to clipboard operation
caddy-tailscale copied to clipboard

Add to "Download Caddy"

Open zorbaTheRainy opened this issue 1 year ago • 6 comments
trafficstars

It would be great if I could download this (with other plug-ins) from Download Caddy.

I am aware I could use xcaddy build but I prefer to have Caddy do the building. It is convenient.

I'll explain my usage case in more detail, I want the caddy binary (with plugins) that I can then slipstream into containers that use both the official Caddy image and my personal Caddy+other-stuff image.
If I was just using the official Caddy image, it wouldn't be that much more difficult to build my own with xcaddy build but since I am using a personal Caddy+ image it becomes a hassle to build that too.

Plus if this was in Caddy Download it would get more attention. (And it is good, it deserves attention)

Thanks

zorbaTheRainy avatar Nov 05 '24 08:11 zorbaTheRainy

I had tried to register it once before and got errors. Apparently it's still erroring:

Image

Error ID, so you don't have to retype it: 5efc5f78-bbe4-4c4c-808f-13ac1112913d

@mholt, I think we might have talked about this once before (I can't remember)? Is that something you can help with?

willnorris avatar Feb 07 '25 16:02 willnorris

@willnorris Huh, yeah, the error is:

unexpected argument to RegisterModule(): &ast.UnaryExpr{OpPos:47791108, Op:17, X:(*ast.CompositeLit)(0xc0416bb740)} - expect either composite literal or new()

https://github.com/tailscale/caddy-tailscale/blob/69a970c84556728bd7e66129154864fa652fc285/app.go#L20

^ Is that the version you're trying to claim? i.e. is this the latest tagged version?

mholt avatar Feb 10 '25 16:02 mholt

^ Is that the version you're trying to claim? i.e. is this the latest tagged version?

That is the latest commit, yes. We actually don't have any tagged version right now, though. Would that be a problem?

willnorris avatar Feb 10 '25 16:02 willnorris

Hmm no, it shouldn't. Is that line a Unary Expression? I am mobile so can't easily look it up right now but I don't think so... I wonder if our registration server is looking at an old version of the code or something?

mholt avatar Feb 10 '25 16:02 mholt

No, it's just a composite literal. I'll try tagging a release just in case that is in fact causing problems. Should probably do that anyway :)

willnorris avatar Feb 11 '25 16:02 willnorris

It should totally be working. I'll try to investigate more when I have a chance. (Sorry!)

mholt avatar Feb 11 '25 16:02 mholt