DynaML icon indicating copy to clipboard operation
DynaML copied to clipboard

Remove println in the code

Open michellemay opened this issue 7 years ago • 2 comments

When running GPRegression model, I find that it is particularly verbose in the console. At first, I thought it was log4j configuration being too verbose. However, grepping in the code, I can see lots of println.

I suggest replacing these println with logger debug or trace level.

michellemay avatar Oct 17 '18 13:10 michellemay

Hi @michellemay, Yes indeed they are mostly pprint.pprintln() statements from ammonite which I inserted. I wanted colour coding of the console logs but it was not possible in log4j.

I guess one way to deal with this is to set some config variable which will avoid executing the println() statements.

Or unless you know of a way to get colour coded console logs?

mandar2812 avatar Oct 17 '18 14:10 mandar2812

I'm not sure about all the other uses, but in AbstractGPRegressionModel, it's regular println("\nGaussian Process Regression")

And to answer your question, I'm not familiar with ammonite at all! I just discovered it exists and plan on using it.

michellemay avatar Oct 17 '18 14:10 michellemay