vagga icon indicating copy to clipboard operation
vagga copied to clipboard

Published 20 hours ago • verified publisher icon tailhook

Container hard-linking To Do

Open tailhook opened this issue 8 years ago • 5 comments

  1. [x] Index after downloading from cache (but first probably we may need to fix #363)
  2. [ ] vagga _verify container-name to test that files have not been modified and still correspond to index file
  3. [ ] vagga _hardlink container-name to hardlink manually
  4. [ ] Hardlinking all over the storage-dir
  5. [x] Verify file permissions when hardlinking
  6. [ ] Is it safe to discard errors when hardlinking?

/cc @anti-social

tailhook avatar Mar 30 '17 12:03 tailhook

Should we check uid and gid before hardlinking? I think so.

anti-social avatar Mar 30 '17 19:03 anti-social

Should we check uid and gid before hardlinking? I think so.

Yes, I think we should.

tailhook avatar Mar 30 '17 20:03 tailhook

Verify file permissions when hardlinking

Already done: https://github.com/tailhook/vagga/blob/master/src/wrapper/build.rs#L579

anti-social avatar May 05 '17 12:05 anti-social

Is it safe to discard errors when hardlinking?

Most of the errors can appear because a container could be deleted when we was creating a hardlink to a file in the container. I think we should ignore those errors as our container was successfully built.

For vagga _hardlink command errors definitely should not be discarded.

anti-social avatar May 05 '17 15:05 anti-social

Most of the errors can appear because a container could be deleted when we was creating a hardlink to a file in the container. I think we should ignore those errors as our container was successfully built.

Basically, this means we need to ignore ENOENT errors but no other. Right?

tailhook avatar May 05 '17 15:05 tailhook