Paul Colomiets

Results 454 comments of Paul Colomiets

> There is a draft [here](https://github.com/kkawakam/rustyline/compare/master...gwenn:prompt#diff-d7f61085d308113c354cf49ee24427df) to support continuation prompt even if there is no highlighting. Well, that was my original approach. But the problem is that you can't implement...

> > Well, that was my original approach. But the problem is that you can't implement `Prompt` for `&str` (because latter is already a "fat" pointer). So it looses the...

> @tailhook maybe you could move the `matches!`-related changes and the new example into separate commits to facilitate the review process. I can move them before, not after. The issue...

Would be nice to have history-navigation-only keybindings anyway, though. As scrolling through text is also annoying.

> * I don't have access to a windows 7 ( If you do, could you please confirm that `\t` are (still) correctly handled. > I don't have too. Since...

> I mean wrap_at_eol was introduced because of a bug on Windows 10 and is ugly. So wrap_at_eol is useless on Unix and may be removed once the bug is...

> > We are always in `wrap_at_eol` mode now. It works fine on unixes too. > > I mean `wrap_at_eol` was introduced because of a bug on Windows 10 and...

> > > > We are always in `wrap_at_eol` mode now. It works fine on unixes too. > > > > > > > > > I mean `wrap_at_eol` was...

> Maybe we should remember that the size cannot be trusted and wrap manually only in this case ? Yes. But this sounds like another branch (e.g. `if` stament) of...

Note to myself: have to retest it on windows after rebase.