Paul Colomiets

Results 454 comments of Paul Colomiets

> How will older version of python work with this change? You will not be able to import the module (because of yield from) The hack like trollius do, is...

Yes, `Enter` and `SubmitOrNewline` usually may be configurable. In `Rustyline` it's a bool [field in enum variant](https://docs.rs/rustyline/latest/rustyline/enum.Cmd.html#variant.AcceptOrInsertLine). On the other hand, I don't know if it makes sense to make...

@fantix, please take a look. It shouldn't be hard, but I'll struggle with testing cloud currently if I try doing it myself.

Yes, we don't have a way currently. Can you describe your use case a bit more? I'm not sure whether asking interactively makes sense here. Or if we ask interactively...

> As for memoizing them across queries, I think that would be very unexpected; > If you run a query with required parameters, you should always provide them. I mean,...

I'm not sure i understand. Do you think that validation works on "Command" but invoke triggers "Action(s)"? This may be a problem too. What if actions changed text in a...

Force-pushed windows fix Also, just to make it clear: #350 is fixed in this PR (thanks for the test).

> I think it would be nice to see a screenshot of this. Here is how we use it in [edgedb-cli](https://github.com/edgedb/edgedb-cli/): ![rectangle-screenshot](https://user-images.githubusercontent.com/321799/80007711-52c59a80-84cf-11ea-9cab-05c68e60bc6c.jpg)

> I am afraid there will be no continuation prompt when colors are disabled (ColorMode::Disabled) or not supported (Windows < 10). I'm okay with that. Do you think this is...

Just fixed two bugs. One of them is because I've untested on windows previously. Now works fine. Anything else to update?