Paul Colomiets

Results 454 comments of Paul Colomiets

Yes. Looks good enough for me. I'm not sure what keyword can be there, and we don't have a keyword after the struct enum member.

> By the way, generic enum types aren't currently supported, are they? No, because it's hard to implement with current macro system.

> I talked with some people on IRC about this, and it seems that an imperfect implementation is doable at least. Could we at least aim for a “bad” temporary...

Well, at least `display()` should have the arguments in the right order (same as in trait). But your examples do not demonstrate real purpose of the thing. There should be...

@jethrogb Well, for the first one I would like to have a crate that does `Join(errors, ", ")` (i.e. a wrapper type that implements Display). It has lot's of use...

Well, unfortunately generic arguments almost impossible to implement in current macro system. At least not for arbitrary generic parameters. Waiting for stable libmacro to make this possible. But with the...

No, I'm not. Looks interesting. Does it work for stable rust?

I think implementation should be similar to #30, except we don't need these attributes in `match` statements. Your one looks fine, but I haven't tested it yet. By the way,...

Okay, I've merged in #30, but can't easily figure out how to fix this one :(

Hm, it's interesting. I usually use something like this: ``` try!(File::open(&filename) .and_then(|mut f| f.read_to_string(&mut input)) .map_err(|e| Error::Io(e, filename.to_path_buf()))); ``` It's a little more verbose. But is it bad enough to...