tailcall
tailcall copied to clipboard
refactor: move entity caching into expression
Summary:
Move cache logical to expression layer.
Issue Reference(s):
/claim #801
Close #801
Build & Testing:
- [x] I ran
cargo test
successfully. - [x] I have run
./lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.
Checklist:
- [ ] I have added relevant unit & integration tests.
- [ ] I have updated the documentation accordingly.
- [x] I have performed a self-review of my code.
Currently, linter report errors:
Checking formatting...
[warn] docs/guides/logging.md
[warn] Code style issues found in the above file. Run Prettier to fix.
But I don't modify related files in this PR.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Codecov Report
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
3958130
) 88.72% compared to head (f986e0c
) 88.76%.
Files | Patch % | Lines |
---|---|---|
src/lambda/cache.rs | 94.54% | 3 Missing :warning: |
src/app_context.rs | 98.92% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 88.72% 88.76% +0.03%
==========================================
Files 94 96 +2
Lines 9591 9642 +51
==========================================
+ Hits 8510 8559 +49
- Misses 1081 1083 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Action required: PR inactive for 2 days. Status update or closure in 5 days.
Currently, linter report error, but I don't modify related files in this PR.
@meskill Could take a look?
@Shylock-Hg can you resolve conflicts. I closed the PR by mistake.
@Shylock-Hg can you resolve conflicts. I closed the PR by mistake.
Ok, done.
@Shylock-Hg can you please resolve the conflicts
@Shylock-Hg We are reimplementing this feature here in #1078 with a few more optimizations and design changes. Will close this for now. Thank you for your time and effort 🙌
/tip 50$
@Shylock-Hg: You just got a $50 tip! We'll notify you once it is processed.
/tip 50$
ok