tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

refactor: move entity caching into expression

Open Shylock-Hg opened this issue 1 year ago • 3 comments

Summary:
Move cache logical to expression layer.

Issue Reference(s):
/claim #801 Close #801

Build & Testing:

  • [x] I ran cargo test successfully.
  • [x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [ ] I have added relevant unit & integration tests.
  • [ ] I have updated the documentation accordingly.
  • [x] I have performed a self-review of my code.

Shylock-Hg avatar Dec 29 '23 08:12 Shylock-Hg

Currently, linter report errors:

Checking formatting...
[warn] docs/guides/logging.md
[warn] Code style issues found in the above file. Run Prettier to fix.

But I don't modify related files in this PR.

Shylock-Hg avatar Dec 30 '23 07:12 Shylock-Hg

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar Jan 01 '24 09:01 github-actions[bot]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3958130) 88.72% compared to head (f986e0c) 88.76%.

Files Patch % Lines
src/lambda/cache.rs 94.54% 3 Missing :warning:
src/app_context.rs 98.92% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   88.72%   88.76%   +0.03%     
==========================================
  Files          94       96       +2     
  Lines        9591     9642      +51     
==========================================
+ Hits         8510     8559      +49     
- Misses       1081     1083       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 02 '24 02:01 codecov[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar Jan 07 '24 11:01 github-actions[bot]

Currently, linter report error, but I don't modify related files in this PR.

Shylock-Hg avatar Jan 12 '24 07:01 Shylock-Hg

@meskill Could take a look?

Shylock-Hg avatar Jan 19 '24 09:01 Shylock-Hg

@Shylock-Hg can you resolve conflicts. I closed the PR by mistake.

tusharmath avatar Jan 26 '24 05:01 tusharmath

@Shylock-Hg can you resolve conflicts. I closed the PR by mistake.

Ok, done.

Shylock-Hg avatar Jan 26 '24 08:01 Shylock-Hg

@Shylock-Hg can you please resolve the conflicts

shashitnak avatar Jan 31 '24 08:01 shashitnak

@Shylock-Hg We are reimplementing this feature here in #1078 with a few more optimizations and design changes. Will close this for now. Thank you for your time and effort 🙌

tusharmath avatar Feb 01 '24 06:02 tusharmath

/tip 50$

tusharmath avatar Feb 01 '24 06:02 tusharmath

@Shylock-Hg: You just got a $50 tip! We'll notify you once it is processed.

algora-pbc[bot] avatar Feb 01 '24 06:02 algora-pbc[bot]

/tip 50$

ok

Shylock-Hg avatar Feb 01 '24 10:02 Shylock-Hg

🎉🎈 @Shylock-Hg has been awarded $50! 🎈🎊

algora-pbc[bot] avatar Feb 02 '24 14:02 algora-pbc[bot]