tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

Added support for Human-Readable Flattened GraphQL Queries

Open ssddOnTop opened this issue 2 years ago • 5 comments

Summary:
Added Support for Human-Readable Flattened GraphQL Queries.

Sample Usage: curl "http://localhost:8000/api/posts?\$=id,user.name&id=1"

Issue Reference(s):
Fixes #560 /claim #560

Build & Testing:

  • [x] I ran cargo test successfully.
  • [x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • [x] I have added relevant unit & integration tests.
  • [ ] I have updated the documentation accordingly (if applicable).
  • [x] I have performed a self-review of my own code.

ssddOnTop avatar Nov 21 '23 10:11 ssddOnTop

@ssddOnTop the url should look like —

Expected

curl "https://example.com/api/user?id=123&$=name,age,address.city,address.state"

Actual

curl "https://example.com/api?user&id=123&$=name,age,address.city,address.state"

ie. the operation name should be part of the route and not the query params.

tusharmath avatar Nov 21 '23 10:11 tusharmath

the operation name should be part of the route and not the query params.

yes I will fix that

But apart from that I think keeping we should give key to the query part i.e. $s and $r part

I think I can remove that part but having some key will be much better to recognize

ssddOnTop avatar Nov 21 '23 10:11 ssddOnTop

@tusharmath can you assign someone to drop a review

ssddOnTop avatar Nov 23 '23 03:11 ssddOnTop

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar Dec 08 '23 06:12 github-actions[bot]

Action required: PR inactive for 2 days. Status update or closure in 5 days.

github-actions[bot] avatar Dec 12 '23 21:12 github-actions[bot]

/tip 50$ @ssddOnTop

tusharmath avatar Jan 04 '24 06:01 tusharmath

🎉🎈 @ssddOnTop has been awarded $50! 🎈🎊

algora-pbc[bot] avatar Jan 04 '24 06:01 algora-pbc[bot]